Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix singleton in StatisticsBackendData [15841] #172

Merged
merged 13 commits into from
Oct 24, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Oct 6, 2022

Fix a Memory Leak problem related with Singleton StatisticsBackendData

This PR fixes some ASAN problems related with StatisticsBackendData, but not all memory errors. Thus the asan job is expected to keep failing.

Merge after:

@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from 3d3735c to b1744c5 Compare October 7, 2022 10:06
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from b1744c5 to 5b7afb5 Compare October 7, 2022 10:06
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from e1a24bb to 98e7802 Compare October 7, 2022 11:02
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from 98e7802 to f5a4a16 Compare October 7, 2022 11:42
@jparisu jparisu temporarily deployed to codecov October 7, 2022 11:42 Inactive
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from f5a4a16 to 4198115 Compare October 10, 2022 05:52
@jparisu jparisu temporarily deployed to codecov October 10, 2022 05:52 Inactive
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from 4198115 to 56aa95a Compare October 10, 2022 06:18
@jparisu jparisu temporarily deployed to codecov October 10, 2022 06:18 Inactive
@jparisu jparisu temporarily deployed to codecov October 10, 2022 14:33 Inactive
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from 8eee71f to a07fbcf Compare October 11, 2022 13:54
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from 863cc1a to d5b4962 Compare October 13, 2022 13:05
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from d5b4962 to bb399c1 Compare October 13, 2022 13:06
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from bb399c1 to c0b6a68 Compare October 13, 2022 14:44
@jparisu jparisu temporarily deployed to codecov October 13, 2022 14:45 Inactive
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from c0b6a68 to 6bc3953 Compare October 14, 2022 07:14
@jparisu jparisu temporarily deployed to codecov October 14, 2022 07:14 Inactive
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from 6bc3953 to aacf5cc Compare October 18, 2022 14:48
@jparisu jparisu temporarily deployed to codecov October 18, 2022 14:48 Inactive
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 57.82% // Head: 58.08% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (cf468ca) compared to base (1e368df).
Patch coverage: 55.43% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   57.82%   58.08%   +0.26%     
==========================================
  Files          31       32       +1     
  Lines        4320     4345      +25     
  Branches     2310     2318       +8     
==========================================
+ Hits         2498     2524      +26     
+ Misses         60       59       -1     
  Partials     1762     1762              
Impacted Files Coverage Δ
src/cpp/database/database.hpp 65.06% <ø> (ø)
src/cpp/StatisticsBackendData.cpp 62.42% <45.45%> (-3.23%) ⬇️
src/cpp/StatisticsBackend.cpp 47.40% <48.88%> (+2.07%) ⬆️
src/cpp/database/database.cpp 51.59% <100.00%> (+0.11%) ⬆️
src/cpp/detail/ScopeExit.hpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jparisu jparisu temporarily deployed to codecov October 19, 2022 05:39 Inactive
src/cpp/StatisticsBackendData.cpp Outdated Show resolved Hide resolved
src/cpp/StatisticsBackendData.cpp Outdated Show resolved Hide resolved
src/cpp/StatisticsBackendData.cpp Outdated Show resolved Hide resolved
src/cpp/StatisticsBackendData.cpp Show resolved Hide resolved
src/cpp/StatisticsBackendData.hpp Outdated Show resolved Hide resolved
test/unittest/Database/DatabaseStatusTests.cpp Outdated Show resolved Hide resolved
src/cpp/StatisticsBackend.cpp Show resolved Hide resolved
src/cpp/StatisticsBackend.cpp Show resolved Hide resolved
@jparisu jparisu temporarily deployed to codecov October 21, 2022 08:46 Inactive
@jparisu jparisu force-pushed the fix/singleton-memory-leak branch from 8796a1e to 412854d Compare October 21, 2022 11:16
@jparisu jparisu temporarily deployed to codecov October 21, 2022 11:16 Inactive
src/cpp/StatisticsBackend.cpp Outdated Show resolved Hide resolved
src/cpp/StatisticsBackend.cpp Outdated Show resolved Hide resolved
src/cpp/detail/ScopeExit.hpp Show resolved Hide resolved
src/cpp/detail/ScopeExit.hpp Outdated Show resolved Hide resolved
src/cpp/detail/ScopeExit.hpp Outdated Show resolved Hide resolved
src/cpp/StatisticsBackend.cpp Outdated Show resolved Hide resolved
src/cpp/database/database.hpp Outdated Show resolved Hide resolved
jparisu and others added 3 commits October 24, 2022 16:06
@MiguelCompany MiguelCompany temporarily deployed to codecov October 24, 2022 14:12 Inactive
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with correct CI

@MiguelCompany MiguelCompany merged commit 04e66d5 into main Oct 24, 2022
@MiguelCompany MiguelCompany deleted the fix/singleton-memory-leak branch October 24, 2022 17:20
@JLBuenoLopez JLBuenoLopez mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants