Make the trigger of the DDS Pipe callbacks configurable #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tempate
force-pushed
the
feature/dynamic_entity_creation
branch
from
4c906f4 to
a2cf1d6
Compare
Tempate
force-pushed
the
feature/dynamic_entity_creation
branch
from
a2cf1d6 to
b467b16
Compare
Tempate
force-pushed
the
feature/manual_topics_conf
branch
from
946b38b to
4871a67
Compare
Tempate
force-pushed
the
feature/dynamic_entity_creation
branch
from
2f20cb6 to
1568f8e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 65.20% 65.15% -0.06%
==========================================
Files 22 22
Lines 1098 1105 +7
Branches 385 389 +4
==========================================
+ Hits 716 720 +4
Misses 136 136
- Partials 246 249 +3 ☔ View full report in Codecov by Sentry. |
jepemi
requested changes
Nov 15, 2023
| @@ -116,14 +116,18 @@ std::shared_ptr<DdsPipe> create_pipe( | |||
| DdsPipeConfiguration ddspipe_configuration; | |||
| ddspipe_configuration.init_enabled = true; | |||
|
|
|||
| // Create the internal communication (built-in) topics | |||
There was a problem hiding this comment.
Update comment, also in similar sections.
juanlofer-eprosima
requested changes
Nov 20, 2023
Tempate
changed the title
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Tempate
force-pushed
the
feature/dynamic_entity_creation
branch
from
71d5739 to
9249a34
Compare
juanlofer-eprosima
requested changes
Nov 22, 2023
Signed-off-by: tempate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, the DDS Pipe's callbacks were only triggered by the discovery of readers, so the Fast-DDS-spy had to simulate the creation of a reader to trigger the creation of the Bridge. In this version, the entity type that triggers the callbacks is configurable, so the Fast-DDS-spy can trigger them with the discovery of writers.
Merge after: