Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually fix a set of Topic QoS, and implement the max-rx-rate and downsampling #55

Merged
merged 15 commits into from
Nov 8, 2023

Conversation

Tempate
Copy link
Contributor

@Tempate Tempate commented Oct 16, 2023

In this version, topics' QoS are configurable. The set of predefined topics' QoS takes precedence over the discovered topics' QoS.

The following features have also been implemented:

  • max-rx-rate (max reception rate): the processing frequency for received samples.
  • downsampling: the proportion of samples to process for received samples.

These features can be configured generically, per participant, and per topic.

Merge after:

docs/rst/notes/forthcoming_version.rst Outdated Show resolved Hide resolved
docs/rst/user_manual/configuration.rst Outdated Show resolved Hide resolved
docs/rst/user_manual/configuration.rst Show resolved Hide resolved
jepemi
jepemi previously approved these changes Oct 20, 2023
Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review all yaml files. There are specs containing qos without qos tag.

docs/rst/user_manual/configuration.rst Show resolved Hide resolved
docs/rst/user_manual/configuration.rst Outdated Show resolved Hide resolved
docs/rst/user_manual/configuration.rst Outdated Show resolved Hide resolved
docs/rst/user_manual/configuration.rst Outdated Show resolved Hide resolved
docs/rst/user_manual/configuration.rst Outdated Show resolved Hide resolved
docs/rst/user_manual/configuration.rst Show resolved Hide resolved
docs/rst/user_manual/configuration.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check .yaml files: configuration_basic.yaml, configuration_discovery_time.yaml, configuration_wrong_empty_arg.yaml, configuration_wrong_type.yaml and fastddsspy_configuration.yaml.
They all include max-history-depth specs qos (should be history-depth, under qos tag)

docs/rst/user_manual/configuration.rst Outdated Show resolved Hide resolved
docs/rst/user_manual/configuration.rst Outdated Show resolved Hide resolved
docs/rst/user_manual/configuration.rst Outdated Show resolved Hide resolved
docs/rst/user_manual/configuration.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update configuration example in resources folder, and remember to also upgrade YAML version in every file/example.

Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builtin-topics no longer have meaning for Fast-DDS-Spy

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Files Coverage Δ
fastddsspy_tool/src/cpp/main.cpp 39.70% <0.00%> (+1.13%) ⬆️
fastddsspy_tool/src/cpp/tool/Controller.cpp 70.30% <0.00%> (ø)
fastddsspy_tool/src/cpp/tool/Backend.cpp 63.63% <25.00%> (-1.67%) ⬇️
...astddsspy_yaml/src/cpp/YamlReaderConfiguration.cpp 40.96% <9.09%> (-2.94%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit 18fdb06 into main Nov 8, 2023
17 of 19 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the feature/manual_topics_conf branch November 8, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants