Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use InternalWriter from DDS-Pipe #114

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

juanlofer-eprosima
Copy link
Contributor

Signed-off-by: Juan Lopez Fernandez <[email protected]>
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.60%. Comparing base (205685c) to head (42cf72f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   60.71%   60.60%   -0.12%     
==========================================
  Files          24       23       -1     
  Lines        1204     1198       -6     
  Branches      441      440       -1     
==========================================
- Hits          731      726       -5     
  Misses        196      196              
+ Partials      277      276       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@EugenioCollado EugenioCollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit b0a3937 into main Dec 19, 2024
20 of 21 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the feature/internal-writer branch December 19, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants