Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21128] Update guards and extenstion .h to .hpp in headers #358

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jun 18, 2024

Description

This PR is the FastDDS Gen counterpart of this FastDDS PR:

This is part of the set of PRs preparing the new major version 3.x in FastDDS. Consequently, it cannot be backported

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v4.0.0 milestone Jun 18, 2024
@JesusPoderoso JesusPoderoso requested a review from EduPonz June 18, 2024 13:13
@JesusPoderoso JesusPoderoso self-assigned this Jun 18, 2024
@JesusPoderoso JesusPoderoso force-pushed the feature/21128 branch 3 times, most recently from 015658f to 75dffe3 Compare June 18, 2024 14:10
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing include guards update in src/main/java/com/eprosima/fastcdr/idl/templates/TypesHeader.stg

@JesusPoderoso JesusPoderoso requested a review from EduPonz June 26, 2024 09:53
EduPonz
EduPonz previously approved these changes Jun 26, 2024
@EduPonz EduPonz merged commit b1f21c3 into master Jun 27, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/21128 branch June 27, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants