Fix DB_RESULT_LIMIT Parsing to Allow Integer Configuration
#999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `DB_RESULT_LIMIT` was treated as a string, preventing it from being set dynamically. This update ensures it is parsed as an integer, fixing the issue. Updated logic: `result_limit = int(config.get("DB_RESULT_LIMIT", 250000))`.
|
@JGreenlee ready for review (albeit small change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the
DB_RESULT_LIMITconfiguration was being treated as a string, preventing it from being set as an integer dynamically. The update ensures the value is properly parsed as an integer, enabling correct configuration usage.Changes
DB_RESULT_LIMITis parsed as an integer.250000if the configuration is not explicitly set.Why This Fix?
DB_RESULT_LIMITwas treated as a string, leading to unexpected behavior when attempting to use or override it.Testing
DB_RESULT_LIMITset: defaults to250000.DB_RESULT_LIMITset to a valid integer: properly reflects the configured value.DB_RESULT_LIMIT(non-numeric string): verified that it raises an appropriate error -- defaults to 250,000 if error