Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: start updating android-core docs for v2 #407

Merged
merged 2 commits into from
Dec 18, 2024
Merged

docs: start updating android-core docs for v2 #407

merged 2 commits into from
Dec 18, 2024

Conversation

harshs-dyte
Copy link
Contributor

Description

Updates the quickstart and pre-call section docs for the v2 SDK

Resolved issues

Fixes MOB-1899
Fixes MOB-1901

Before submitting the PR, please take the following into consideration

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

@harshs-dyte harshs-dyte changed the title Start updating android-core docs for v2 docs: start updating android-core docs for v2 Dec 18, 2024
@swapnilmadavi swapnilmadavi self-requested a review December 18, 2024 07:32
swapnilmadavi
swapnilmadavi approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@swapnilmadavi swapnilmadavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshs-dyte Apart from a few minor things, PR looks good.
Please check the comments.

docs/android-core/quickstart.mdx Outdated Show resolved Hide resolved
docs/android-core/pre-call/1-media-preview.mdx Outdated Show resolved Hide resolved
docs/android-core/pre-call/1-media-preview.mdx Outdated Show resolved Hide resolved
docs/android-core/pre-call/1-media-preview.mdx Outdated Show resolved Hide resolved
docs/android-core/pre-call/1-media-preview.mdx Outdated Show resolved Hide resolved
docs/android-core/pre-call/1-media-preview.mdx Show resolved Hide resolved
docs/android-core/pre-call/4-waiting-room.mdx Outdated Show resolved Hide resolved
docs/android-core/pre-call/4-waiting-room.mdx Outdated Show resolved Hide resolved
docs/android-core/pre-call/4-waiting-room.mdx
</Tabs>

Host can use [these methods to accept/reject participants](/android-core/participants#waiting-room-methods).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(to-do): We will need to update this link after we update the Participants section.
MOB-1921

@harshs-dyte harshs-dyte merged commit 798f54e into dyte-io:main Dec 18, 2024
1 check passed
@harshs-dyte harshs-dyte deleted the hs/mobile-v2 branch December 18, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilmadavi swapnilmadavi swapnilmadavi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshs-dyte @swapnilmadavi