fix(txfees, gamm): remove taker fee swap event from trade events #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsitrin
commented
Dec 3, 2024
| @@ -17,57 +15,17 @@ func (k Keeper) chargeTakerFee( | |||
| ctx sdk.Context, | |||
| takerFeeCoin sdk.Coin, | |||
| sender sdk.AccAddress, | |||
| route poolmanagertypes.SwapAmountInRoute, | |||
There was a problem hiding this comment.
chargeTakerFee used to swap if it's unknown denom.
as we don't expect pools with non-dym, we don't need this logic.
And if we would like it in the future, it needs to be part of the x/txfees logic anyway
There was a problem hiding this comment.
I don't think it's correct we don't expect pools with non-dym.
we may have usdc pools.
mtsitrin
commented
Dec 3, 2024
| @@ -128,44 +131,44 @@ func ValueFromPtr[T any](ptr *T) (zero T) { | |||
| } | |||
|
|
|||
| // swapFeeToBaseDenom swaps the taker fee coin to the base denom. | |||
| // If the fee token is unknown, it is sent to the community pool. | |||
| // Returns error if the fee token is unknown or if swapping fails. | |||
| // The fee must be sent to the txfees module account beforehand. | |||
| func (k Keeper) swapFeeToBaseDenom( | |||
There was a problem hiding this comment.
swapFeeToBaseDenom was cleaned of the communityPool logic.
now handled by caller, based on returned err
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x/gamm
x/txfees
swapFeeToBaseDenomfrom community pool logick.poolManager.RouteExactAmountInwith cacheCtx to drop the internal events