feat: taker fee should be passed to txfees module #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsitrin
commented
Dec 6, 2023
There was a problem hiding this comment.
extracted from x/poolmanager/types/routes.go
mtsitrin
commented
Dec 6, 2023
x/poolmanager/types/routes.go
Outdated
| tokenInDenom string, | ||
| swapFee sdk.Dec, | ||
| ) (tokenIn sdk.Coin, err error) | ||
| type SwapRoutesUnion struct { |
There was a problem hiding this comment.
union struct so we could have common API for taker fee from both SwapIn and SwapOut
omritoptix
reviewed
Dec 7, 2023
| func (k *Keeper) SetPoolManager(poolManager types.PoolManager) { | ||
| k.poolManager = poolManager | ||
| } | ||
|
|
||
| // SetTxFees sets the tx fees keeper. | ||
| // must be called when initializing the keeper. | ||
| func (k *Keeper) SetTxFees(txfees types.TxFeeKeeper) { |
There was a problem hiding this comment.
Why is it not being initialized when we init the keeper?
There was a problem hiding this comment.
theres a dependecy cycle
someone needs to be initialized first
x/gamm/keeper/msg_server.go
Outdated
| OutRoutes: nil, | ||
| Type: "in", | ||
| } | ||
| err = server.keeper.chargeTakerFee(ctx, takerFeesCoins, sender, routesForTakerFee, msg.Routes[len(msg.Routes)-1].TokenOutDenom) |
There was a problem hiding this comment.
isn't it supposed to be msg.Routes[0].TokenOutDenom to get the out token of the first people given that it's an "in" route and this msg.Routes[len(msg.Routes)-1] should be for the Out route?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the taker fee logic once the txfee module is available.
taker fee checked vs the supported fees on txfee module.
if not supported, it will be swapped on the first pool on the route (to get a whitelisted pool asset)
than it sent to the txfee module to be burned