Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(celestia): use fixed delay in repeat attempts #753

Merged
merged 7 commits into from
May 2, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented May 1, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Close #752

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner May 1, 2024 12:34
Copy link
Contributor

@srene srene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, its better to keep the backoff function, since there is a min and max delay. In case both values are the same, the delay will be fixed and will not increase over time. What i think we need is to be able to set those values in the config file, so nodes can choose the behavior, fixed or increasing delay, in case problems with batch submissions.

@danwt
Copy link
Contributor Author

danwt commented May 1, 2024

ok I will add another pr to expose config

@danwt
Copy link
Contributor Author

danwt commented May 1, 2024

you can still merge this?

@danwt danwt requested review from srene and zale144 May 1, 2024 13:08
@danwt
Copy link
Contributor Author

danwt commented May 1, 2024

see #757 for exposing config

da/celestia/config.go Show resolved Hide resolved
@danwt danwt requested a review from zale144 May 1, 2024 14:59
zale144
zale144 previously approved these changes May 2, 2024
@danwt danwt requested a review from zale144 May 2, 2024 09:30
@danwt danwt merged commit 53002b0 into main May 2, 2024
@danwt danwt deleted the danwt/752-revert-expo-backoff-in-sublayers branch May 2, 2024 14:07
omritoptix pushed a commit that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revert expo backoff in da/settlement
4 participants