fix: retries for hub client #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c534d1d.
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 44.04% 44.05%
=======================================
Files 120 120
Lines 16531 16550 +19
=======================================
+ Hits 7281 7291 +10
- Misses 8219 8224 +5
- Partials 1031 1035 +4 ☔ View full report in Codecov by Sentry. |
danwt
requested changes
Apr 5, 2024
settlement/dymension/dymension.go
Outdated
Comment on lines
559
to
560
| }, retry.Context(d.ctx), retry.LastErrorOnly(true), | ||
| retry.Delay(d.batchRetryDelay), retry.Attempts(d.batchRetryAttempts), retry.MaxDelay(batchRetryMaxDelay)) |
There was a problem hiding this comment.
this code is duplicated a lot
can we dry out by extracting d.retry(fn) which uses these default args?
|
It seems GetSequencers and GetBatchAtIndex dont require the rollapp id as args |
omritoptix
reviewed
Apr 6, 2024
yes it requires refactoring (#629) |
danwt
approved these changes
Apr 8, 2024
Comment on lines
280
to
282
| func (m *Manager) getLatestBatchFromSL(ctx context.Context) (*settlement.ResultRetrieveBatch, error) { | ||
| var resultRetrieveBatch *settlement.ResultRetrieveBatch | ||
| var err error | ||
| // Get latest batch from SL | ||
| err = retry.Do( | ||
| func() error { | ||
| resultRetrieveBatch, err = m.settlementClient.RetrieveBatch() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| }, | ||
| retry.LastErrorOnly(true), | ||
| retry.Context(ctx), | ||
| retry.Attempts(1), | ||
| ) | ||
| if err != nil { | ||
| return resultRetrieveBatch, err | ||
| } | ||
| return resultRetrieveBatch, nil | ||
| return m.settlementClient.RetrieveBatch() | ||
| } |
There was a problem hiding this comment.
this function could be inlined, it seems
There was a problem hiding this comment.
right. done in other PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
Close #551
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: