Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos && re-run make proto-gen #539

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

bodhi-crypo
Copy link
Contributor

PR Standards

  1. fix some typos in .proto
  2. re run make proto-gen make sure consistency of generated files
@bodhi-crypo ➜ /workspaces/dymint (main) $ sudo make proto-gen
Generating Protobuf files..
./proto/gen.sh
Deleting contents of ./p2p/pb
Deleting contents of ./pb/pb
Deleting contents of ./test/pb
Deleting contents of ./types/pb
Copying generated proto files to ./p2p/pb
Copying generated proto files to ./pb/pb
cp: cannot stat './proto/pb/pb/*': No such file or directory
Copying generated proto files to ./test/pb
Copying generated proto files to ./types/pb
Deleting proto pb dir

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@bodhi-crypo bodhi-crypo requested a review from a team as a code owner December 19, 2023 15:28
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2b2cdf) 52.46% compared to head (d33b664) 52.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   52.46%   52.46%           
=======================================
  Files         100      100           
  Lines       14717    14717           
=======================================
  Hits         7722     7722           
  Misses       5886     5886           
  Partials     1109     1109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix omritoptix merged commit c68e540 into dymensionxyz:main Dec 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants