Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: returns descriptive error in case no sequencer registered on the hub #305

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Apr 24, 2023

PR Standards

Opening a pull request should be able to meet the following requirements:


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner April 24, 2023 14:25
@mtsitrin mtsitrin linked an issue Apr 24, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #305 (b5b1808) into main (c217bda) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   52.18%   52.30%   +0.12%     
==========================================
  Files          70       70              
  Lines       12570    12566       -4     
==========================================
+ Hits         6560     6573      +13     
+ Misses       5078     5066      -12     
+ Partials      932      927       -5     
Impacted Files Coverage Δ
settlement/base.go 79.87% <ø> (+0.51%) ⬆️
settlement/dymension/dymension.go 21.53% <ø> (+0.23%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mtsitrin mtsitrin merged commit 1f3cc05 into main Apr 30, 2023
@mtsitrin mtsitrin deleted the mtsitrin/187-non-indicative-error-message-if-sequencer-not-registered-on-the-hub branch April 30, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non indicative error message if sequencer not registered on the hub
2 participants