feat(rpc): add da, rollapp params to status query #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mtsitrin
previously approved these changes
Jan 13, 2025
da/stub/stub.go
Outdated
| } | ||
|
|
||
| func (l Layer) Init(config []byte, pubsubServer *pubsub.Server, kvStore store.KV, logger types.Logger, options ...da.Option) error { | ||
| //TODO implement me |
There was a problem hiding this comment.
ah
it's autogenerated by ide
but yet will do
There was a problem hiding this comment.
not big fan of this panicking stub struct
the da interface should be lean so it will be reasonable for each layer to implement all the methods
There was a problem hiding this comment.
Don't forget, it is optional to use it. For example, when writing a testing impl
Each real DA should implement it
There was a problem hiding this comment.
right,
though not sure why u added it to all the implementations
type DataAvailabilityLayerClient struct {
stub.Layer
mtsitrin
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #1024
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: