Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reconnect full node to sequencer with configurable time check #556

Merged
merged 8 commits into from
Jan 15, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Jan 2, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (379b93e) 48.17% compared to head (0022634) 48.21%.

Files Patch % Lines
p2p/client.go 75.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
+ Coverage   48.17%   48.21%   +0.03%     
==========================================
  Files          98       98              
  Lines       14484    14505      +21     
==========================================
+ Hits         6978     6993      +15     
- Misses       6535     6541       +6     
  Partials      971      971              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix omritoptix changed the title feat: adding a new function to reconnect to sequencer automatically in case of disconnection with configurable time check feat: reconnect to sequencer automatically in case of disconnection with configurable time check Jan 3, 2024
@omritoptix omritoptix changed the title feat: reconnect to sequencer automatically in case of disconnection with configurable time check feat: reconnect full node to sequencer with configurable time check Jan 3, 2024
@srene srene merged commit 9129983 into main Jan 15, 2024
5 checks passed
@srene srene deleted the fix/546-reconnecting_to_sequencer branch January 15, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p2p
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full node stops receiving gossiped blocks when disconnected from sequencer
4 participants