fix: address review comments

dymensionxyz · Apr 7, 2022 · eb2e87c · eb2e87c
1 parent 8a758cb
commit eb2e87c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/block/manager.go b/block/manager.go
@@ -24,6 +24,7 @@ import (
 	"github.com/celestiaorg/optimint/types"
 )
 
+// defaultDABlockTime is used only if DABlockTime is not configured for manager
 const defaultDABlockTime = 30 * time.Second
 
 // Manager is responsible for aggregating transactions into blocks.
@@ -212,7 +213,6 @@ func (m *Manager) SyncLoop(ctx context.Context) {
 				delete(m.syncCache, currentHeight+1)
 			}
 		case <-ctx.Done():
-			m.logger.Debug("exiting SyncLoop")
 			return
 		}
 	}

diff --git a/config/config.go b/config/config.go
@@ -32,7 +32,9 @@ type NodeConfig struct {
 
 // BlockManagerConfig consists of all parameters required by BlockManagerConfig
 type BlockManagerConfig struct {
-	BlockTime   time.Duration `mapstructure:"block_time"`
+	// BlockTime defines how often new blocks are produced
+	BlockTime time.Duration `mapstructure:"block_time"`
+	// DABlockTime informs about block time of underlying data availability layer
 	DABlockTime time.Duration `mapstructure:"da_block_time"`
 	NamespaceID [8]byte       `mapstructure:"namespace_id"`
 }