feat (l2): hard fork #591
feat (l2): hard fork #591
Conversation
…ension-rdk into tip/rdk_hardfork
x/sequencers/keeper/msg_server.go
Outdated
| proto.MessageName(&vestingtypes.PermanentLockedAccount{}): {}, | ||
| } | ||
|
|
||
| const BumpSequence = 1_000_000_000 |
There was a problem hiding this comment.
| const BumpSequence = 1_000_000_000 | |
| const BumpSequence = 10_000_000_000 |
x/sequencers/keeper/msg_server.go
Outdated
|
|
||
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
|
|
||
| var allErrors error |
There was a problem hiding this comment.
This is weird, you're making a stack of errors
You should only call Join once
x/sequencers/keeper/msg_server.go
Outdated
| err := m.bumpAccountSequence(ctx, account) | ||
| allErrors = errors.Join(allErrors, err) | ||
| } else { | ||
| // check if it can be handled by something custom | ||
| for _, f := range m.accountBumpFilters { | ||
| toBump, err := f(accType, account) | ||
| if err != nil { | ||
| allErrors = errors.Join(allErrors, fmt.Errorf("filter account: %w", err)) | ||
| return false | ||
| } | ||
| if toBump { | ||
| err := m.bumpAccountSequence(ctx, account) | ||
| allErrors = errors.Join(allErrors, err) | ||
| break | ||
| } |
There was a problem hiding this comment.
Can refac to only call bump once
x/sequencers/keeper/msg_server.go
Outdated
|
|
||
| err := m.upgradeKeeper.ScheduleUpgrade(ctx, upgradetypes.Plan{ | ||
| Name: fmt.Sprintf("upgrade-drs-%d", drs.DrsVersion), | ||
| Height: ctx.BlockHeight() + 1, |
There was a problem hiding this comment.
agree, not sure why the upgrade is scheduled in the next block and not the same..
x/sequencers/keeper/msg_server.go
Outdated
| func (m msgServer) updateDrsVersion(ctx sdk.Context, drsVersion uint64) { | ||
| oldParams := m.rollapParamsKeeper.GetParams(ctx) | ||
| oldParams.DrsVersion = uint32(drsVersion) | ||
| m.rollapParamsKeeper.SetParams(ctx, oldParams) | ||
| } |
There was a problem hiding this comment.
is it easier to just leave this to the upgrade?
There was a problem hiding this comment.
I think is better here, the upgrade handler I think is responsability of the rollapp, as it kind of case by case and it can't be generic?
|
+1 height is a blocker |
x/sequencers/keeper/msg_server.go
Outdated
|
|
||
| err := m.upgradeKeeper.ScheduleUpgrade(ctx, upgradetypes.Plan{ | ||
| Name: fmt.Sprintf("upgrade-drs-%d", drs.DrsVersion), | ||
| Height: ctx.BlockHeight() + 1, |
There was a problem hiding this comment.
agree, not sure why the upgrade is scheduled in the next block and not the same..
x/sequencers/keeper/msg_server.go
Outdated
|
|
||
| m.updateDrsVersion(ctx, drs.DrsVersion) | ||
|
|
||
| err := m.upgradeKeeper.ScheduleUpgrade(ctx, upgradetypes.Plan{ |
There was a problem hiding this comment.
i think besides the scheduleupgrade we need to call the SetUpgradeHandler, otherwise it the node stops necause it does not find an upgraded handler for the scheduled upgrade.
There was a problem hiding this comment.
but we dont have a way to setup a generic handler
There was a problem hiding this comment.
The way it works is that it uses the upgrade name to get the handler, I understand when the fork happens there will be a consensus on the next version of the app to use. And this version should include a handler.
Hey sergi -Not all upgrades will require sequence bump |
| currentParams := m.rollapParamsKeeper.GetParams(ctx) | ||
| if currentParams.DrsVersion == uint32(newVersion) { | ||
| return false | ||
| } | ||
|
|
||
| currentParams.DrsVersion = uint32(newVersion) | ||
| m.rollapParamsKeeper.SetParams(ctx, currentParams) | ||
|
|
There was a problem hiding this comment.
still not sure about this but nvm
|
|
||
| if needUpgrade { | ||
| err := m.upgradeKeeper.ScheduleUpgrade(ctx, upgradetypes.Plan{ | ||
| Name: fmt.Sprintf("upgrade-drs-%d", drs.DrsVersion), |
There was a problem hiding this comment.
not sure how this name is going to work since in general you will need to upgrade from a specific version TO a specific version
| // AccountBumpFilterFunc is a function signature that filters accounts whose sequence should be bumped. | ||
| // IT is passed the account proto name to avoid re-computing it, it is also passed the account in case | ||
| // casting is needed. | ||
| type AccountBumpFilterFunc = func(accountProtoName string, account authtypes.AccountI) (bool, error) |
There was a problem hiding this comment.
As this type is addition to the handleAccounts list
I would call it differently.
somthing like AccountBumpExtraTypes
| accType := proto.MessageName(account) | ||
| _, ok := handleAccounts[accType] | ||
| i := 0 | ||
| for !ok && i < len(m.accountBumpFilters) { |
There was a problem hiding this comment.
if a filter returns ok=true, the loop still continues instead of breaking and calling bumpAccountSequence
| accType := proto.MessageName(account) | ||
| _, ok := handleAccounts[accType] | ||
| i := 0 | ||
| for !ok && i < len(m.accountBumpFilters) { |
There was a problem hiding this comment.
why not using range m.accountBumpFilters
Description
Closes #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
For Reviewer:
After reviewer approval: