Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consensus messages #563

Merged
merged 3 commits into from
Oct 8, 2024
Merged

feat: consensus messages #563

merged 3 commits into from
Oct 8, 2024

Conversation

faultytolly
Copy link
Contributor

@faultytolly faultytolly commented Sep 27, 2024

Description

ADR link https://www.notion.so/dymension/ADR-x-Sequencer-Messages-34f95e2b579e458e8bb4252da19324bd

Closes https://github.com/dymensionxyz/epics/issues/1


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@keruch keruch marked this pull request as ready for review October 2, 2024 18:35
@keruch keruch requested a review from a team as a code owner October 2, 2024 18:35
Copy link
Contributor

@keruch keruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some nits. besides that, everything is fine!

server/consensus/handler.go Outdated Show resolved Hide resolved
server/consensus/handler.go Outdated Show resolved Hide resolved
@keruch
Copy link
Contributor

keruch commented Oct 2, 2024

build and lint fail for some strange reasons

@faultytolly faultytolly requested a review from keruch October 4, 2024 07:02
@omritoptix omritoptix merged commit baa5f01 into main Oct 8, 2024
7 checks passed
@omritoptix omritoptix deleted the feat/consensus-messages branch October 8, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants