Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rollapp params): remove maxgas from rollappparams #524

Merged
merged 11 commits into from
Aug 30, 2024
Merged

feat(rollapp params): remove maxgas from rollappparams #524

merged 11 commits into from
Aug 30, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Aug 26, 2024 •
edited
Loading

Description

Closes #525

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@srene srene requested a review from a team as a code owner August 26, 2024 15:00
@srene srene self-assigned this Aug 26, 2024
@srene srene marked this pull request as draft August 26, 2024 15:00
@srene srene marked this pull request as ready for review August 26, 2024 16:36
@srene srene changed the base branch from main to srene/516-rollapp_params_query August 26, 2024 16:38
@srene srene marked this pull request as draft August 27, 2024 09:35
@srene srene changed the title feat(rollapp_params): change blockmaxgas from uint32 to int64 feat(rollapp_params): remove maxgas maxsize from rollappparams Aug 27, 2024
@srene srene force-pushed the srene/523-blockmaxgas-toin64 branch from 2a41c3c to eb82a2c Compare August 27, 2024 10:17
@srene srene changed the title feat(rollapp_params): remove maxgas maxsize from rollappparams feat(rollapp_params): remove maxgas from rollappparams Aug 28, 2024
@srene srene force-pushed the srene/523-blockmaxgas-toin64 branch from 25502fb to bd46997 Compare August 29, 2024 10:09
@srene srene marked this pull request as ready for review August 29, 2024 11:03
@srene srene force-pushed the srene/516-rollapp_params_query branch from 5c86ff0 to 2c2849b Compare August 29, 2024 14:00
Base automatically changed from srene/516-rollapp_params_query to main August 29, 2024 14:13
@srene srene force-pushed the srene/523-blockmaxgas-toin64 branch from bd46997 to 671bbf9 Compare August 29, 2024 14:40
@srene srene force-pushed the srene/523-blockmaxgas-toin64 branch from 671bbf9 to 831a733 Compare August 29, 2024 14:46
@omritoptix omritoptix changed the title feat(rollapp_params): remove maxgas from rollappparams feat(rollapp params): remove maxgas from rollappparams Aug 29, 2024
omritoptix
omritoptix reviewed Aug 30, 2024
View reviewed changes
x/rollappparams/types/genesis_test.go
expectedErr: true,
},
{
name: "block max size too small",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we remove the max size test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason for that, it was by mistake. tests readded

omritoptix
omritoptix reviewed Aug 30, 2024
View reviewed changes
x/rollappparams/keeper/keeper.go Outdated
@@ -56,3 +46,8 @@ func (k Keeper) Version(ctx sdk.Context) (res string) {
k.paramSpace.Get(ctx, types.KeyVersion, &res)
return
}

func (k Keeper) BlockMaxSize(ctx sdk.Context) (res uint32) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we name it BlockMaxBytes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@srene srene requested a review from omritoptix August 30, 2024 13:06
@omritoptix omritoptix merged commit 4b256cd into main Aug 30, 2024
7 checks passed
@omritoptix omritoptix deleted the srene/523-blockmaxgas-toin64 branch August 30, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees

@srene srene

Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove blockmaxgas from rollappparams
2 participants
@srene @omritoptix