Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollapp params): add ability to query rollapp params #521

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Aug 26, 2024

Description


Closes #516

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@srene srene self-assigned this Aug 26, 2024
@srene srene requested a review from a team as a code owner August 26, 2024 10:25
@srene srene marked this pull request as draft August 26, 2024 10:25
@srene srene marked this pull request as ready for review August 26, 2024 16:36
@srene srene changed the base branch from main to srene/519-rollapp_params_commit_rename August 26, 2024 16:38
omritoptix
omritoptix previously approved these changes Aug 29, 2024
Base automatically changed from srene/519-rollapp_params_commit_rename to main August 29, 2024 13:50
@omritoptix omritoptix dismissed their stale review August 29, 2024 13:50

The base branch was changed.

@srene srene force-pushed the srene/516-rollapp_params_query branch from 5c86ff0 to 2c2849b Compare August 29, 2024 14:00
@omritoptix omritoptix changed the title feat(rollapp_params): add ability to query rollapp params feat(rollapp params): add ability to query rollapp params Aug 29, 2024
@omritoptix omritoptix merged commit d117bfe into main Aug 29, 2024
5 of 6 checks passed
@omritoptix omritoptix deleted the srene/516-rollapp_params_query branch August 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to query rollapp params
2 participants