Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollapp): Add pruning command #484

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented Jul 22, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Closes #482

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@zale144 zale144 self-assigned this Jul 22, 2024
@zale144 zale144 requested a review from a team as a code owner July 22, 2024 10:02
@danwt danwt merged commit f87d7fc into main Jul 22, 2024
8 checks passed
@danwt danwt deleted the zale144/482-add-pruning-command branch July 22, 2024 14:30
omritoptix pushed a commit that referenced this pull request Jul 30, 2024
omritoptix pushed a commit that referenced this pull request Jul 30, 2024
omritoptix pushed a commit that referenced this pull request Aug 13, 2024
omritoptix pushed a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose pruning one-off command as in the sdk
3 participants