Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(epoch): remove epoch count check from validateGenesis #461

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Chore(epoch): remove epoch count check from validateGenesis #461

merged 1 commit into from
Jun 20, 2024

Conversation

hoangdv2429
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@hoangdv2429 hoangdv2429 requested a review from a team as a code owner June 20, 2024 09:53
@mtsitrin mtsitrin merged commit a8b97b8 into main Jun 20, 2024
8 checks passed
@mtsitrin mtsitrin deleted the chore/remove_epoch_count_check branch June 20, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoangdv2429 @mtsitrin