Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proto): use buf, like we do on dymension repo #432

Merged
merged 6 commits into from
May 27, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented May 24, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

Makefile Show resolved Hide resolved
@danwt danwt requested a review from hoangdv2429 May 24, 2024 14:39
@mtsitrin mtsitrin merged commit f2d2ad1 into main May 27, 2024
8 checks passed
@mtsitrin mtsitrin deleted the danwt/430-fix-proto-setup-0001 branch May 27, 2024 06:52
@0xbcdev
Copy link

0xbcdev commented Jun 4, 2024

@danwt the Makefile missed setting version to variables:
https://github.com/dymensionxyz/dymension/blob/983dd904dacc3b5a6ff5c3122b02fdbf450cd730/Makefile#L13-L20

The dependencies are not accurate either, rdk does not deps to Ethermint, Osmosis but still fetch proto?

dymension-rdk/Makefile

Lines 87 to 109 in f2d2ad1

mkdir -p "$(THIRD_PARTY_DIR)/ethermint_tmp" && \
cd "$(THIRD_PARTY_DIR)/ethermint_tmp" && \
git init && \
git remote add origin "https://github.com/dymensionxyz/ethermint.git" && \
git config core.sparseCheckout true && \
printf "proto\nthird_party\n" > .git/info/sparse-checkout && \
git fetch --depth=1 origin "$(DEPS_ETHERMINT_VERSION)" && \
git checkout FETCH_HEAD && \
rm -f ./proto/buf.* && \
mv ./proto/* ..
rm -rf "$(THIRD_PARTY_DIR)/ethermint_tmp"
mkdir -p "$(THIRD_PARTY_DIR)/osmosis_tmp" && \
cd "$(THIRD_PARTY_DIR)/osmosis_tmp" && \
git init && \
git remote add origin "https://github.com/dymensionxyz/osmosis.git" && \
git config core.sparseCheckout true && \
printf "proto\nthird_party\n" > .git/info/sparse-checkout && \
git fetch --depth=1 origin "$(DEPS_OSMOSIS_VERSION)" && \
git checkout FETCH_HEAD && \
rm -f ./proto/buf.* && \
mv ./proto/* ..
rm -rf "$(THIRD_PARTY_DIR)/osmosis_tmp"

@danwt
Copy link
Contributor Author

danwt commented Jun 4, 2024

@0xbcdev Thanks for pointing that out I was in a rush
I'll fix it

@danwt danwt mentioned this pull request Jun 4, 2024
@danwt
Copy link
Contributor Author

danwt commented Jun 5, 2024

@0xbcdev please could you review #441
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants