Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(mint): more test coverage for mint #354

Merged
merged 8 commits into from
Apr 1, 2024

Conversation

hoangdv2429
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


Table style test scenario and more test cases.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@hoangdv2429 hoangdv2429 requested a review from a team as a code owner March 29, 2024 18:04
@omritoptix
Copy link
Contributor

seems like currently we're only testing if the after epoch end coins were minted but we don't actually check the amount is the expected amount

@hoangdv2429
Copy link
Contributor Author

I think this one cover the minting amount https://github.com/decentrio/dymension-rdk/blob/d1879871eda9f7b3a8af0b8364caed9c4c2aef50/x/mint/keeper/mint_test.go#L20-L21. But I agree we should also check the minting amount here as well

@mtsitrin mtsitrin merged commit d8af752 into dymensionxyz:main Apr 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants