Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(mint): add test for mint #353

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

hoangdv2429
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


Closes #344

I think we need more test cases, but currently for testing the hook. This is probably enough.

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@hoangdv2429 hoangdv2429 requested a review from a team as a code owner March 28, 2024 17:31
@hoangdv2429 hoangdv2429 marked this pull request as draft March 28, 2024 17:34
@hoangdv2429 hoangdv2429 marked this pull request as ready for review March 29, 2024 05:23
@omritoptix omritoptix changed the title Feat: Add test for mint tests(mint): add test for mint Mar 29, 2024
@omritoptix omritoptix merged commit ffef9ab into dymensionxyz:main Mar 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mint simultation tests
2 participants