Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Upgrade go 1.22.1 #334

Merged
merged 10 commits into from
Mar 19, 2024
Merged

Conversation

hoangdv2429
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

Close #331


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@hoangdv2429 hoangdv2429 requested a review from a team as a code owner March 19, 2024 04:44
@hoangdv2429 hoangdv2429 marked this pull request as draft March 19, 2024 04:48
@hoangdv2429 hoangdv2429 marked this pull request as ready for review March 19, 2024 10:21
omritoptix
omritoptix previously approved these changes Mar 19, 2024
@omritoptix omritoptix merged commit 906d5ea into dymensionxyz:main Mar 19, 2024
1 of 2 checks passed
@mtsitrin
Copy link
Collaborator

@hoangdv2429 make proto-gen stopped working after this merge
can u take a look?

@hoangdv2429
Copy link
Contributor Author

@mtsitrin Can you add buf before [protoc ](https://github.com/decentrio/dymension-rdk/blob/4286ec7529b2073c71653375f3a630652a2eae6c/scripts/protocgen.sh#L7) in protocgen.sh. I'm using buf version 1.3 so it's not working with the old script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to go v1.22
3 participants