Revert "Drop inaccessible subclasses from refineUsingParent"

dwijnand · Nov 6, 2024 · cecd053 · cecd053
1 parent 63849a0
commit cecd053
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 20 deletions.
diff --git a/compiler/src/dotty/tools/dotc/core/Decorators.scala b/compiler/src/dotty/tools/dotc/core/Decorators.scala
@@ -292,7 +292,7 @@ object Decorators {
       case _ => String.valueOf(x).nn
 
     /** Returns the simple class name of `x`. */
-    def className: String = if x == null then "<null>" else x.getClass.getSimpleName.nn
+    def className: String = x.getClass.getSimpleName.nn
 
   extension [T](x: T)
     def assertingErrorsReported(using Context): T = {

diff --git a/compiler/src/dotty/tools/dotc/core/TypeOps.scala b/compiler/src/dotty/tools/dotc/core/TypeOps.scala
@@ -930,11 +930,7 @@ object TypeOps:
       for tp <- mixins.reverseIterator do
         protoTp1 <:< tp
       maximizeType(protoTp1, NoSpan)
-      val inst = wildApprox(protoTp1)
-      if !inst.classSymbol.exists then
-        // E.g. i21790, can't instantiate S#CA as a subtype of O.A, because O.CA isn't accessible
-        NoType
-      else inst
+      wildApprox(protoTp1)
     }
 
     if (protoTp1 <:< tp2) instantiate()

diff --git a/tests/pos/i21790.scala b/tests/pos/i21790.scala