Semver binary version. #101
Conversation
A first draft. Semver binary.
|
I found 1 tiny bit problem. This binary (even musl statically linked) doesn't work inside Alpine linux (docker builder) because of incorrect ELF signature and it wanting to use libc runtime. There is some work to enable rustc to compile it with musl, but not complete yet. |
|
Thanks @lunemec ! I might take a day or two to get to this; this is a release week for Rust, so I'm quite busy. We'll see though. |
| @@ -13,6 +13,13 @@ Semantic version parsing and comparison. | |||
|
|
|||
| [dependencies] | |||
| semver-parser = "0.6.1" | |||
| regex = "0.1" | |||
There was a problem hiding this comment.
so, one unfortunate aspect of this is that we just removed the regex dependency because it's too heavy. maybe we can not use it here? let' see from below...
There was a problem hiding this comment.
I'm thinking maybe split the binary into separate project, just for the binary. This way you don't pull the dependencies with the library. (Although you'll get them with semver-parser anyways :))
There was a problem hiding this comment.
yeah, this may or may not be worth it. i'll give it some thought
| lazy_static = "0.2.1" | ||
|
|
||
| [dependencies.clap] | ||
| version = "~2.20.0" |
There was a problem hiding this comment.
In general, you should drop the ~; ^ is the default and is most appropriate, imho.
| } | ||
| } | ||
|
|
||
| // Borrowed from semver-parser (common is not public). |
There was a problem hiding this comment.
Yeah, so this is where regexes get used. I wonder if we can maybe pull this stuff out into an internal crate that both share, so we can not use the regex.
There was a problem hiding this comment.
Well, making common public would help, I was planning to make a PR on that, after you took a look at this (I'm not that proficient in rust). Also, since I'm using regex here, but it is used in the chain - semver -> semver-parser -> regex, does it make a difference for the user? They have to get it anyways...
There was a problem hiding this comment.
semver parser no longer uses regex; I cut a new release without it :)
|
Ok, I'll cancel this PR, try to rewrite using semver-parser (the new one without regexes). I think I'll send a PR making the method I need public in semver-parser and use that. |
Semver binary.