Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When applicable, use the cargo executable that we were invoked from #46

Merged
merged 1 commit into from
Sep 25, 2021

Conversation

tgnottingham
Copy link
Contributor

No description provided.

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit dee9630 into dtolnay:master Sep 25, 2021
@tgnottingham tgnottingham deleted the invoke-originating-cargo branch September 25, 2021 05:29
@tgnottingham
Copy link
Contributor Author

tgnottingham commented Sep 25, 2021

Sure!

Just for background for anyone stumbling across this in the future, this came up because we're bypassing the cargo shim and directly invoking particular cargo executables in the rust-lang/rustc-perf collector. So, we would run something like ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo llvm-lines, and cargo-llvm-lines would itself end up running ~/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/cargo rustc, which would lead to some issues in the collector. Anyway, should be good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants