Fix dotnet#123 - Union types without sub-classes should be sealed

dsyme · Jan 27, 2015 · 8dc04ab · brodyberg · Jan 28, 2015 · dsyme
1 parent 742c133
commit 8dc04ab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/ilx/cu_erase.fs b/src/ilx/cu_erase.fs
@@ -1059,9 +1059,6 @@ let rec convClassUnionDef cenv enc td cud =
             |> List.filter (fun pd -> not (cud.cudHasHelpers = SpecialFSharpListHelpers && (pd.Name = "Empty"  || pd.Name = "IsEmpty"  )) &&
                                       not (cud.cudHasHelpers = SpecialFSharpOptionHelpers && (pd.Name = "Value" || pd.Name = "None")))
 
-    let casesTypeDef = 
-           None
-
     let enumTypeDef = 
         // The nested Tags type is elided if there is only one tag
         // The Tag property is NOT elided if there is only one tag
@@ -1095,15 +1092,14 @@ let rec convClassUnionDef cenv enc td cud =
 
     let baseTypeDef = 
         { Name = td.Name;
-          NestedTypes = mkILTypeDefs (Option.toList casesTypeDef @ 
-                               Option.toList enumTypeDef @ 
+          NestedTypes = mkILTypeDefs (Option.toList enumTypeDef @ 
                                altTypeDefs @ 
                                altDebugTypeDefs @
                                (convTypeDefs cenv (enc@[td]) td.NestedTypes).AsList);
           GenericParams= td.GenericParams;
           Access = td.Access;
           IsAbstract = isAbstract;
-          IsSealed = false;
+          IsSealed = altTypeDefs.IsEmpty;
           IsSerializable=td.IsSerializable;
           IsComInterop=false;
           Layout=td.Layout; 

diff --git a/tests/fsharp/core/array/test.fsx b/tests/fsharp/core/array/test.fsx
@@ -1368,6 +1368,8 @@ module bug872632 =
 
     do check "bug872632" Foo.x.Length 8
 
+    do check "vwllfewlkefwl" (typedefof<list<int>>.IsSealed) true
+
 module manyIndexes =
     open System