-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add options to not return the raw data and unpaginate profile fields #25
base: master
Are you sure you want to change the base?
Conversation
Hey @chkuendig, would you mind adding some tests for these new options? |
@chkuendig seems that tests on Travis CI is successful, but anyway, it's new features. Please, cover them with tests. Thank you. |
anything missing before you can merge this? |
merged recent changes in upstream. anything holding this back from being merged? |
if (this._unpaginateFields.length > 0) { | ||
var unpaginateFields = this._unpaginateFields; | ||
|
||
var unpaginateField = function(pointer) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that this fn has side-effects and located in closure
@drudge any suggestions? |
Hi,
for some reason GitHub put together both commits in one PR:
Cheers