Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event) : add delhome event #1455

Open
wants to merge 2 commits into
base: 1.6.x
Choose a base branch
from

Conversation

NewZAZ
Copy link

@NewZAZ NewZAZ commented Jan 28, 2023

  • Implements event on delhome command

Need update kyori :
net.kyori:adventure-platform-bukkit:jar:4.0.0-20210914.041527-93 was not found in https://papermc.io/repo/repository/maven-public/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of papermc has elapsed or updates are forced

@NewZAZ
Copy link
Author

NewZAZ commented Jan 28, 2023

@drtshock

@mbax
Copy link
Collaborator

mbax commented Jan 28, 2023

Thank you for this contribution! A few thoughts:

  1. Are you sure it even compiles? I can't see this working without any package or import declarations in the new class.
  2. Currently where the event is called, it would charge users and then deny them the deletion. Can you swap things around to test if they can afford, then event, then charge?
  3. "Need update kyori" - This plugin builds against version 4.2.0, not 4.0.0-SNAPSHOT. I don't know how you're getting that.

@NewZAZ
Copy link
Author

NewZAZ commented Jan 29, 2023

Thank you for this contribution! A few thoughts:

  1. Are you sure it even compiles? I can't see this working without any package or import declarations in the new class.
  2. Currently where the event is called, it would charge users and then deny them the deletion. Can you swap things around to test if they can afford, then event, then charge?
  3. "Need update kyori" - This plugin builds against version 4.2.0, not 4.0.0-SNAPSHOT. I don't know how you're getting that.

Hi, i can't compile plugin because kyori make error, I don't know why because version is 4.2.0 not 4.0.0

@mbax
Copy link
Collaborator

mbax commented Jan 29, 2023

Can you dump the dependency tree on your end? I don't see it when I run mvn dependency:tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants