Ensure messages from packets are expected length and discard otherwis… #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. Discard unknown message types
| @@ -44,14 +44,20 @@ | |||
| final int messageLength = packetBuffer.getInt(); | |||
| Log.d(TAG, String.format("Received message %d of with value of length %d. Remaining buffer size is %d", messageType, messageLength, packetBuffer.remaining())); | |||
|
|
|||
| if (messageLength > packetBuffer.remaining()) { | |||
There was a problem hiding this comment.
@chaviw stores packetBuffer.remaining() into a variable since it's used more than once.
Fixed issues highlighted by the unit tests.
m4gr3d
added a commit
that referenced
this pull request
Nov 11, 2015
Ensure messages from packets are expected length and discard otherwis…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e. Discard unknown message types