Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added geotag api #305

Merged
merged 10 commits into from
Oct 17, 2015
Merged

Added geotag api #305

merged 10 commits into from
Oct 17, 2015

Conversation

chaviw
Copy link

@chaviw chaviw commented Oct 15, 2015

No description provided.

@@ -0,0 +1,229 @@
package com.o3dr.android.client.utils;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaviw create a geotag package for this class.

getInstance().execute(new Runnable() {
@Override
public void run() {
File saveDir = new File(getSaveRootDir(context).getPath(), "GeoTag");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaviw you can pass a File object argument to the File constructor, so there's no need to use getPath().

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
File dirs[] = context.getExternalFilesDirs(null);
for (File dir : dirs) {
if (Environment.isExternalStorageRemovable(dir)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaviw check that dir is not null before checking if it's removable.

m4gr3d added a commit that referenced this pull request Oct 17, 2015
@m4gr3d m4gr3d merged commit 9e10116 into develop Oct 17, 2015
@m4gr3d m4gr3d deleted the add_geotag_api branch October 17, 2015 04:28
@ebennb
Copy link

ebennb commented Dec 13, 2015

Hi, how would i use this to geotag my GoPro images taken by my Solo drone? Thanks!

@chaviw
Copy link
Author

chaviw commented Dec 14, 2015

This api is intended to help developers integrate geotagging in their app. It requires some data from the vehicle, which the app will need to extract. We are working on adding the feature to the Tower app that will use this api to allow geotagging to work in specific situations.

When that feature is added to Tower, we will update the release notes and documentation explaining how and when this feature can be used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants