Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retry mechanism in read blob metadata #1617

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Sep 16, 2024

Relevant Issue (if applicable)

#1613

Details

When reading blob size from blob metadata, we should retry reading from the remote if an error occurs.

  • Handle the BackendError.
  • Set the max retry times to 3.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested a review from a team as a code owner September 16, 2024 02:41
@Desiki-high Desiki-high requested review from imeoer, jiangliu and hsiangkao and removed request for a team September 16, 2024 02:41
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 16 lines in your changes missing coverage. Please review.

Project coverage is 61.27%. Comparing base (7fc9ede) to head (e04b5ca).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
storage/src/meta/mod.rs 27.27% 15 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1617      +/-   ##
==========================================
- Coverage   61.29%   61.27%   -0.02%     
==========================================
  Files         146      146              
  Lines       48143    48156      +13     
  Branches    46110    46123      +13     
==========================================
+ Hits        29507    29509       +2     
- Misses      17075    17085      +10     
- Partials     1561     1562       +1     
Files with missing lines Coverage Δ
storage/src/meta/mod.rs 72.21% <27.27%> (-0.31%) ⬇️

... and 3 files with indirect coverage changes

@Desiki-high Desiki-high force-pushed the fix/retry-blob-meta branch 5 times, most recently from 0eb353e to 0f123e8 Compare September 18, 2024 04:13
When read blob size from blob metadata, we should retry read from the remote if error occurs.
Also set the max retry times is 3.

Signed-off-by: Yadong Ding <[email protected]>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desiki-high Desiki-high merged commit 849591a into dragonflyoss:master Sep 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants