nydusify: small improvements for mount & check subcommands #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `--prefetch` option for enabling full image data prefetch. - Support `HTTP_PROXY` / `HTTPS_PROXY` env for enabling proxy for nydusd. - Change nydusd log level to `warn` for mount & check subcommands. Signed-off-by: Yan Song <[email protected]>
imeoer
requested review from
ccx1024cc,
gaius-qi and
power-more
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1615 +/- ##
==========================================
- Coverage 61.44% 61.38% -0.06%
==========================================
Files 145 146 +1
Lines 48032 48040 +8
Branches 46007 46007
==========================================
- Hits 29512 29490 -22
- Misses 16963 16987 +24
- Partials 1557 1563 +6
|
NehemiahMi
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--prefetchoption for enabling full image data prefetch.HTTP_PROXY/HTTPS_PROXYenv for enabling proxy for nydusd.warnfor mount & check subcommands.Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.