-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add smoke test for nydusd failover #1529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loheagn
requested review from
imeoer,
jiangliu and
hsiangkao
and removed request for
a team
December 25, 2023 02:49
Desiki-high
reviewed
Dec 25, 2023
Desiki-high
reviewed
Dec 25, 2023
loheagn
force-pushed
the
failover-smoketest
branch
from
December 25, 2023 03:04
5b6284d
to
a314e60
Compare
This comment was marked as resolved.
This comment was marked as resolved.
jiangliu
force-pushed
the
failover-smoketest
branch
from
December 25, 2023 03:30
a314e60
to
1d395f7
Compare
Desiki-high
force-pushed
the
failover-smoketest
branch
from
December 25, 2023 06:45
1d395f7
to
5a90cc8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1529 +/- ##
=======================================
Coverage 61.29% 61.29%
=======================================
Files 145 145
Lines 46617 46617
Branches 44153 44153
=======================================
Hits 28575 28575
Misses 16591 16591
Partials 1451 1451 |
Desiki-high
reviewed
Dec 25, 2023
Signed-off-by: loheagn <[email protected]>
loheagn
force-pushed
the
failover-smoketest
branch
from
December 25, 2023 08:21
5a90cc8
to
9628741
Compare
Desiki-high
approved these changes
Dec 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
None
Details
This patch adds a smoke test for nydusd failover.
The patch also includes:
SnapshotterClient
to facilitate test code in controlling nydus-snapshotter.ConvertImage
.Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.