Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add smoke test for nydusd failover #1529

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

loheagn
Copy link
Contributor

@loheagn loheagn commented Dec 25, 2023

Relevant Issue (if applicable)

None

Details

This patch adds a smoke test for nydusd failover.

The patch also includes:

  1. Addition of SnapshotterClient to facilitate test code in controlling nydus-snapshotter.
  2. Extraction of the utility method ConvertImage.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@loheagn loheagn requested review from a team as code owners December 25, 2023 02:49
@loheagn loheagn requested review from imeoer, jiangliu and hsiangkao and removed request for a team December 25, 2023 02:49
@Desiki-high

This comment was marked as resolved.

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17c373f) 61.29% compared to head (9628741) 61.29%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1529   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files         145      145           
  Lines       46617    46617           
  Branches    44153    44153           
=======================================
  Hits        28575    28575           
  Misses      16591    16591           
  Partials     1451     1451           

see 1 file with indirect coverage changes

Copy link
Member

@Desiki-high Desiki-high left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desiki-high Desiki-high merged commit 7f27b7a into dragonflyoss:master Dec 25, 2023
22 checks passed
@loheagn loheagn deleted the failover-smoketest branch December 25, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants