Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add go module unit coverage statistics in Codecov #1524

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

resolve #1518.

Details

  1. Add contrib-unit-test-coverage job to test the Golang modules in contrib.
  2. Upload both rust and golang coverage files to Codecov.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Use contrib-tes job to test the golang modules in contrib.

Signed-off-by: Yadong Ding <[email protected]>
@Desiki-high Desiki-high requested review from a team as code owners December 18, 2023 10:48
@Desiki-high Desiki-high requested review from liubin, liubogithub, gaius-qi, bergwolf and hsiangkao and removed request for a team December 18, 2023 10:48
@Desiki-high Desiki-high changed the title Makefile/coverage codecov tests: add go module unit coverage statistics in Codecov Dec 18, 2023
@Desiki-high Desiki-high force-pushed the makefile/coverage-codecov branch 3 times, most recently from 335ebce to 7bd960a Compare December 18, 2023 11:40
@Desiki-high

This comment has been minimized.

@Desiki-high Desiki-high force-pushed the makefile/coverage-codecov branch from 7bd960a to 1300c48 Compare December 18, 2023 12:09
@Desiki-high

This comment has been minimized.

@Desiki-high Desiki-high changed the title tests: add go module unit coverage statistics in Codecov [WIP]tests: add go module unit coverage statistics in Codecov Dec 18, 2023
@Desiki-high Desiki-high force-pushed the makefile/coverage-codecov branch from 1300c48 to b24a4c5 Compare December 18, 2023 12:30
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #1524 (b24a4c5) into master (0458817) will decrease coverage by 1.84%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
- Coverage   62.72%   60.88%   -1.84%     
==========================================
  Files         129      141      +12     
  Lines       44153    46277    +2124     
  Branches    44153    44153              
==========================================
+ Hits        27695    28178     +483     
- Misses      15087    16658    +1571     
- Partials     1371     1441      +70     

see 12 files with indirect coverage changes

@Desiki-high

This comment has been minimized.

@Desiki-high Desiki-high changed the title [WIP]tests: add go module unit coverage statistics in Codecov tests: add go module unit coverage statistics in Codecov Dec 18, 2023
@Desiki-high
Copy link
Member Author

Desiki-high commented Dec 18, 2023

The coverage has decreased due to the addition of new go modules.
image

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit a4ec9b8 into dragonflyoss:master Dec 19, 2023
14 of 15 checks passed
@adamqqqplay
Copy link
Member

@Desiki-high Thank you for your great work, really helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need add go module unit coverage statistics in Codecov
3 participants