-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove go test cover #1514
Conversation
In golang smoke test, go test don't need coverage analysis and create coverage profile. Signed-off-by: Yadong Ding <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
+ Coverage 62.72% 62.73% +0.01%
==========================================
Files 129 129
Lines 44158 44158
Branches 44158 44158
==========================================
+ Hits 27697 27702 +5
+ Misses 15092 15088 -4
+ Partials 1369 1368 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Desiki-high Does this step affect execution time?
I'm not sure about the execution time. I need to test it. |
In my local machine or Github Action, this step doesn't affect execution time. In my point, the |
@Desiki-high Ok, I see. In addition, if you have time, can you help add the coverage statistics of nydusify and other go modules to codecov? Thanks in advance. |
I can have a try. |
Thanks for your help. I will submit an new issue to track this. |
I have creatd at #1517. |
Relevant Issue (if applicable)
Details
In golang smoke test, go test don't need coverage analysis and create coverage profile.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.