smoke: fix stable version for compatibility test #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And let's make stable version name as a env. Signed-off-by: Yan Song <[email protected]>
imeoer
requested review from
liubin,
liubogithub and
changweige
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1462 +/- ##
=======================================
Coverage 44.37% 44.37%
=======================================
Files 123 123
Lines 38896 38896
Branches 38896 38896
=======================================
Hits 17259 17259
Misses 20696 20696
Partials 941 941 |
imeoer
commented
Nov 2, 2023
| @@ -16,6 +16,8 @@ env: | |||
| CARGO_TERM_COLOR: always | |||
| IMAGE: wordpress | |||
| TAG: 6.1.1 | |||
| NYDUS_STABLE_VERSION: v2.2.3 | |||
There was a problem hiding this comment.
Let's fix https://github.com/dragonflyoss/nydus/actions/runs/6715346171/job/18249975611?pr=1461 first, maybe the better way is to get the latest stable version name using GitHub API.
There was a problem hiding this comment.
bergwolf
approved these changes
Nov 2, 2023
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And let's make stable version name as a env.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.