add upgrade unit test #1440
Merged
add upgrade unit test #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hijackthe2
requested review from
liubogithub,
luodw and
changweige
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1440 +/- ##
==========================================
+ Coverage 46.26% 46.32% +0.06%
==========================================
Files 123 123
Lines 38878 38905 +27
Branches 38878 38905 +27
==========================================
+ Hits 17987 18023 +36
+ Misses 19918 19908 -10
- Partials 973 974 +1
|
imeoer
reviewed
Oct 16, 2023
| assert!(FailoverPolicy::try_from(s).is_err()); | ||
| } | ||
|
|
||
| let str = String::from("flush"); |
There was a problem hiding this comment.
Thanks for the test! Is it necessary to test String?
There was a problem hiding this comment.
Thank you for response and suggestion! I test String type transform here to increase code coverage. Indeed, testing String type is optional.
|
Also please remove the unnecessary commits. |
|
@hijackthe2 Let's remove the unnecessary commits and merge it, thanks! |
hijackthe2
force-pushed
the
unit-test
branch
4 times, most recently
from
3130df6 to
ea15402
Compare
imeoer
approved these changes
Oct 24, 2023
test type transformation between struct FailoverPolicy and String/&str
imeoer
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add unit test in service/src/upgrade.rs
Details
add function test_failover_policy to test FailoverPolicy::try_from
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.