-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: notifying incosistent fs version problem with exit code #1424
Merged
imeoer
merged 1 commit into
dragonflyoss:master
from
PerseidMeteor:feat_inconsistent_fsversion
Sep 25, 2023
Merged
feat: notifying incosistent fs version problem with exit code #1424
imeoer
merged 1 commit into
dragonflyoss:master
from
PerseidMeteor:feat_inconsistent_fsversion
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerseidMeteor
requested review from
luodw,
gaius-qi and
hsiangkao
and removed request for
a team
September 13, 2023 14:44
PerseidMeteor
changed the title
feat: notifying incosistent fs version problem with exit code
[WIP]feat: notifying incosistent fs version problem with exit code
Sep 13, 2023
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
- Coverage 46.44% 46.43% -0.01%
==========================================
Files 123 123
Lines 38702 38705 +3
Branches 38702 38705 +3
==========================================
- Hits 17974 17973 -1
- Misses 19755 19759 +4
Partials 973 973
|
PerseidMeteor
changed the title
[WIP]feat: notifying incosistent fs version problem with exit code
feat: notifying incosistent fs version problem with exit code
Sep 20, 2023
PerseidMeteor
force-pushed
the
feat_inconsistent_fsversion
branch
6 times, most recently
from
September 20, 2023 14:31
44575e4
to
ef67eb7
Compare
imeoer
reviewed
Sep 21, 2023
imeoer
reviewed
Sep 21, 2023
imeoer
reviewed
Sep 21, 2023
PerseidMeteor
force-pushed
the
feat_inconsistent_fsversion
branch
2 times, most recently
from
September 22, 2023 09:48
dc8da46
to
51093ea
Compare
imeoer
reviewed
Sep 23, 2023
imeoer
reviewed
Sep 23, 2023
PerseidMeteor
force-pushed
the
feat_inconsistent_fsversion
branch
2 times, most recently
from
September 24, 2023 05:03
31de6d7
to
0cf7469
Compare
imeoer
reviewed
Sep 24, 2023
imeoer
reviewed
Sep 24, 2023
imeoer
reviewed
Sep 25, 2023
PerseidMeteor
force-pushed
the
feat_inconsistent_fsversion
branch
from
September 25, 2023 05:30
0cf7469
to
8d09de2
Compare
imeoer
reviewed
Sep 25, 2023
imeoer
reviewed
Sep 25, 2023
PerseidMeteor
force-pushed
the
feat_inconsistent_fsversion
branch
from
September 25, 2023 07:29
8d09de2
to
f31ff4f
Compare
PerseidMeteor
force-pushed
the
feat_inconsistent_fsversion
branch
from
September 25, 2023 12:31
a745c0e
to
278915b
Compare
If acceld converts with different fs version cache, leading to an inconsistent fs version problem when merging into boostrap layer. So we need to notify acceld that an inconsistent version occured and handle this error. Signed-off-by: YuQiang <[email protected]>
PerseidMeteor
force-pushed
the
feat_inconsistent_fsversion
branch
from
September 25, 2023 12:49
f0a721d
to
a4e40a3
Compare
imeoer
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If acceld converts with different fs version cache, leading to an inconsistent fs version problem when merging into boostrap layer. So we need to notify acceld that an inconsistent version occured and handle this error.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Define
InconsistentFsVersion
withthiserror
and check error type after merge, if is fs version inconsistent problem, just return status code 2.Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.