Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use /dev/stdin as SOURCE path for image build #1409

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

zyfjeff
Copy link
Contributor

@zyfjeff zyfjeff commented Aug 29, 2023

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Support use /dev/stdin as SOURCE path for image build

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@zyfjeff zyfjeff requested a review from a team as a code owner August 29, 2023 02:19
@zyfjeff zyfjeff requested review from liubogithub, jiangliu and hsiangkao and removed request for a team August 29, 2023 02:19
@anolis-bot
Copy link
Collaborator

@zyfjeff , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90705

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1409 (89165de) into master (1abf0ae) will decrease coverage by 0.17%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
- Coverage   46.45%   46.28%   -0.17%     
==========================================
  Files         123      123              
  Lines       38602    38607       +5     
  Branches    38602    38607       +5     
==========================================
- Hits        17931    17871      -60     
- Misses      19702    19765      +63     
- Partials      969      971       +2     
Files Changed Coverage Δ
src/bin/nydus-image/main.rs 41.58% <71.42%> (+0.59%) ⬆️

... and 7 files with indirect coverage changes

@zyfjeff zyfjeff force-pushed the support-char-devcie branch 2 times, most recently from cfade1b to 89165de Compare August 29, 2023 02:30
@imeoer imeoer merged commit 49cc3f9 into dragonflyoss:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants