-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: simplify mirror implementation #1375
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1375 +/- ##
==========================================
+ Coverage 46.17% 46.26% +0.09%
==========================================
Files 122 122
Lines 37913 37970 +57
Branches 37913 37970 +57
==========================================
+ Hits 17506 17567 +61
+ Misses 19489 19481 -8
- Partials 918 922 +4
|
c5c719b
to
4513dce
Compare
@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/85389 |
4513dce
to
c5d4144
Compare
@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/85390 |
c5d4144
to
ff5f83f
Compare
@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/85391 |
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/85392 |
@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/85393 |
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
ce9efc9
to
d0ca988
Compare
@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/85533 |
Nydusd uses a registry backend which generates a surge of blob requests without auth tokens on initial startup. This caused mirror backends (e.g. dragonfly) to process very slowly, the commit fixes this problem. It implements waiting for the first blob request to complete before making other blob requests, this ensures the first request caches a valid registry auth token, and subsequent concurrent blob requests can reuse the cached token. This change is worthwhile to reduce concurrent token requests, it also makes the behavior consistent with containerd, which first requests the image manifest and caches the token before concurrently requesting blobs. Signed-off-by: Yan Song <[email protected]>
The auth_through option adds user burden to configure the mirror and understand its meaning, and since we have optimized handling of concurrent token requests, this option can now be removed. Signed-off-by: Yan Song <[email protected]>
- Make registry mirror log pretty; - Adjust token refresh interval automatically; Signed-off-by: Yan Song <[email protected]>
d0ca988
to
dc83210
Compare
@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/85559 |
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge it first, will update nydus-snapshotter later. |
@jiangliu PTAL. |
We have removed the `auth_through` option in dragonflyoss/nydus#1375 Let's remove it in snapshotter, since its default value is false, there is no compatibility impact. Signed-off-by: Yan Song <[email protected]>
We have removed the `auth_through` option in dragonflyoss/nydus#1375 Let's remove it in snapshotter, since its default value is false, there is no compatibility impact. Signed-off-by: Yan Song <[email protected]>
We have removed the `auth_through` option in dragonflyoss/nydus#1375 Let's remove it in snapshotter, since its default value is false, there is no compatibility impact. Signed-off-by: Yan Song <[email protected]>
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.