-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action:clean cache after branch closes #1281
Conversation
Signed-off-by: Yadong Ding <[email protected]>
@Desiki-high , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/73613 |
Codecov Report
@@ Coverage Diff @@
## master #1281 +/- ##
==========================================
- Coverage 45.08% 45.07% -0.02%
==========================================
Files 126 126
Lines 37403 37403
Branches 37403 37403
==========================================
- Hits 16863 16858 -5
- Misses 19649 19656 +7
+ Partials 891 889 -2 |
Are we seeing any issues with this behavior? IOW, the description is not clear why we need to clean up caches instead of letting GH handle it. |
In our repo, the cache approach total cache storage limit always happened. The reson is pr changed the depences, such as go.sum or Cargo. toml, created new cache. After pr merged, GH will created new cache, the cache created by pr branch is still exited. |
The specific scenario is that the cache I saved in benchmark is deleted by GH once. Since benchmark doesn't run every day, the last cache might be replaced by the one generated by pr. I'm just trying to reduce the possibility of this happening. |
@Desiki-high , The CI test is completed, please check result:
Congratulations, your test job passed! |
Caches have branch scope restrictions in place, which means some caches have limited usage options. We should clean cache after branch closes.
See https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries.