-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action: add zran-no-prefetch benchmark and make smoke.yml tidy #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Desiki-high
commented
Apr 21, 2023
•
edited
Loading
edited
- Benchmark in smoke test has too many same steps, we can move them to shell and make smoke.yml tidy by prepare_env.sh and benchmark_summary.sh.
- Add zran-no-prefetch benchmark.
- Change the benchmark-result order, set the oci in the first.
- Since action: fix checkout on pull_request_target #1238, we move the benchmark-result from PR comment to action summary, we should enable benchmark-result in push and schedule.
- Use the stable wordpress tag 6.11.
- Delete the artifacts after benchmark-result download all artifacts. Certainly, the nydus-integration-test had downloaded the artifacts.
Desiki-high
requested review from
liubin,
imeoer and
changweige
and removed request for
a team
April 21, 2023 05:50
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #1239 +/- ##
==========================================
- Coverage 41.36% 41.34% -0.02%
==========================================
Files 126 126
Lines 37336 37336
Branches 37336 37336
==========================================
- Hits 15443 15438 -5
- Misses 21158 21165 +7
+ Partials 735 733 -2 |
Desiki-high
force-pushed
the
smoke-clear
branch
3 times, most recently
from
April 21, 2023 06:15
504655b
to
9d19eea
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Desiki-high
force-pushed
the
smoke-clear
branch
2 times, most recently
from
April 21, 2023 06:56
22dbd08
to
82d3610
Compare
Desiki-high
changed the title
[WIP]clear the smoke.yml
[WIP]action: add zran-no-prefetch benchmark and make smoke.yml tidy
Apr 21, 2023
Desiki-high
force-pushed
the
smoke-clear
branch
from
April 21, 2023 07:32
1328e28
to
b206fc9
Compare
Desiki-high
changed the title
[WIP]action: add zran-no-prefetch benchmark and make smoke.yml tidy
action: add zran-no-prefetch benchmark and make smoke.yml tidy
Apr 21, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Desiki-high
force-pushed
the
smoke-clear
branch
from
April 21, 2023 08:23
52b825c
to
aab24cb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Desiki-high
force-pushed
the
smoke-clear
branch
from
April 22, 2023 05:52
08eab6e
to
5181f3c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Desiki-high <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Desiki-high
force-pushed
the
smoke-clear
branch
from
April 22, 2023 06:11
5181f3c
to
a9dfa53
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1. prepare_env.sh for prepare container environment. 2. benchmark_summary.sh for benchmark-result to summary result. Signed-off-by: Desiki-high <[email protected]>
1. add the zran without prefetch benchmark. 2. move the same steps to prepare_env.sh. 3. move benchmark summary script to benchmark_summary.sh. 3. change the benchmark-result order and enable in push and schedule. 4. set stable the wordpress tag 6.1.1. 5. delete the artifacts after benchmark-result download all artifacts. Signed-off-by: Desiki-high <[email protected]>
Desiki-high
force-pushed
the
smoke-clear
branch
from
April 22, 2023 06:25
a9dfa53
to
86992c5
Compare
@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69408 |
This comment was marked as outdated.
This comment was marked as outdated.
@Desiki-high , The CI test is completed, please check result:
Congratulations, your test job passed! |
imeoer
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.