feat: support the arg batch-size for small chunks mergence for nydusify #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Desiki-high , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/65414 |
|
@Desiki-high , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/65415 |
|
@Desiki-high , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@Desiki-high , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
adamqqqplay
changed the title
Desiki-high
force-pushed
the
batchsize
branch
3 times, most recently
from
eed55eb to
af17aa5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1206 +/- ##
==========================================
+ Coverage 45.01% 45.02% +0.01%
==========================================
Files 126 126
Lines 37382 37382
Branches 37382 37382
==========================================
+ Hits 16828 16832 +4
+ Misses 19667 19661 -6
- Partials 887 889 +2 |
Desiki-high
requested review from
bergwolf,
liubin and
liubogithub
and removed request for
a team
Desiki-high
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Desiki-high
requested review from
ccx1024cc
and removed request for
bergwolf,
liubin and
liubogithub
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Desiki-high <[email protected]>
|
@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69609 |
|
@Desiki-high , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
imeoer
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the batch-size arg for nydusify and the batch-size arg is new feature for nydus-image, which support merge small file chunks into one batch chunk.
That is the second part of work , the first part work is in nydus-snapshotter
This PR is related to #1202.