-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move RAFS filesystem builder into nydus-rafs crate #1141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize ChunkWrapper to reduce memory consumption by only instantialing the chunk info object when needed. Signed-off-by: Jiang Liu <[email protected]>
Optimize InodeWrapper to reduce memory consumption by only instantialing the inode object when needed. Signed-off-by: Jiang Liu <[email protected]>
Move builder from nydus-image into rafs, so it can be reused. Signed-off-by: Jiang Liu <[email protected]>
Organize immutable fields of Node into a new struct NodeInfo, to reduce memory consumption and copy operations. Signed-off-by: Jiang Liu <[email protected]>
Move overlay related code into builder/core/overlay.rs, for better maintenance. Signed-off-by: Jiang Liu <[email protected]>
Move RAFSv6 builder related code into a dedicated file. Signed-off-by: Jiang Liu <[email protected]>
Refine builder/Node related code for maintenance. Signed-off-by: Jiang Liu <[email protected]>
Refine RAFS v6 builder implementation by: - introduce helper Node::v6_dump_inode() to reduce duplicated code - introduce helper BuildContext::v6_block_addr() Signed-off-by: Jiang Liu <[email protected]>
Refine builder Bootstrap implementation for maintenance. Signed-off-by: Jiang Liu <[email protected]>
Refine prefetch and chunk dictionary in builder for maintenance. Signed-off-by: Jiang Liu <[email protected]>
jiangliu
requested review from
imeoer,
changweige and
hsiangkao
and removed request for
a team
March 6, 2023 13:32
@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/54863 |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
Which component is supposed to reuse the builder? |
Image-rs for confidential containers:) |
imeoer
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move RAFS filesystem builder into nydus-rafs crate so it can be reused. Also reduce memory consumption during image conversion.