Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work directory is not clean up as description of parameter. #1162

Closed
ccx1024cc opened this issue Mar 21, 2023 · 0 comments · Fixed by #1164
Closed

Work directory is not clean up as description of parameter. #1162

ccx1024cc opened this issue Mar 21, 2023 · 0 comments · Fixed by #1164
Assignees
@ccx1024cc

Comments

@ccx1024cc
Copy link
Contributor

ccx1024cc commented Mar 21, 2023 •
edited
Loading

Version

# Nydusify version
Version : v2.2.0-79-g6ab15d85b
Revision        : 6ab15d85bfea4aa44c67214739b350d2667e40e1
Go version      : go1.19.7
Build time      : 2023-03-21T11:20:18

Reproduction

# sudo nydusify convert --source wordpress --target localhost:5077/nydus/wordpress:2.2-v6 --fs-version 5
Stdout skipped

# tree -L 2 ./tmp
./tmp
├── blobs
│   └── sha256
└── ingest
    ├── 7971d83ddc026c2ab318d190204fe0fabeaf1c4c487817c0c5f1b92e6585a999
    └── f327d92d9126c51c9076b06588350d2fadb6026274a44b4483843d745b59aa07

5 directories, 0 files
@ccx1024cc ccx1024cc self-assigned this Mar 21, 2023
imeoer added a commit to imeoer/image-service that referenced this issue Mar 21, 2023
@imeoer
nydusify: cleanup work directory when conversion finish
dd8573c 
Remove the work directory to clean up the temporary image
blob data after the conversion is finished.

We should only clean up before the workdir directory exists,
otherwise it may delete user data by mistake.

Fix: dragonflyoss#1162

Signed-off-by: Yan Song <[email protected]>
@imeoer imeoer mentioned this issue Mar 21, 2023
Merged
imeoer added a commit to imeoer/image-service that referenced this issue Mar 21, 2023
@imeoer
nydusify: cleanup work directory when conversion finish
a1ed1e4 
Remove the work directory to clean up the temporary image
blob data after the conversion is finished.

We should only clean up when the work directory not exists
before, otherwise it may delete user data by mistake.

Fix: dragonflyoss#1162

Signed-off-by: Yan Song <[email protected]>
imeoer added a commit to imeoer/image-service that referenced this issue Mar 21, 2023
@imeoer
nydusify: cleanup work directory when conversion finish
5708cb2 
Remove the work directory to clean up the temporary image
blob data after the conversion is finished.

We should only clean up when the work directory not exists
before, otherwise it may delete user data by mistake.

Fix: dragonflyoss#1162

Signed-off-by: Yan Song <[email protected]>
imeoer added a commit to imeoer/image-service that referenced this issue Mar 21, 2023
@imeoer
nydusify: cleanup work directory when conversion finish
41ec556 
Remove the work directory to clean up the temporary image
blob data after the conversion is finished.

We should only clean up when the work directory not exists
before, otherwise it may delete user data by mistake.

Fix: dragonflyoss#1162

Signed-off-by: Yan Song <[email protected]>
ccx1024cc pushed a commit to ccx1024cc/image-service that referenced this issue Mar 23, 2023
@imeoer
nydusify: cleanup work directory when conversion finish
43a42c1 
Remove the work directory to clean up the temporary image
blob data after the conversion is finished.

We should only clean up when the work directory not exists
before, otherwise it may delete user data by mistake.

Fix: dragonflyoss#1162

Signed-off-by: Yan Song <[email protected]>
ccx1024cc pushed a commit to ccx1024cc/image-service that referenced this issue Mar 23, 2023
@imeoer
nydusify: cleanup work directory when conversion finish
d885d1a 
Remove the work directory to clean up the temporary image
blob data after the conversion is finished.

We should only clean up when the work directory not exists
before, otherwise it may delete user data by mistake.

Fix: dragonflyoss#1162

Signed-off-by: Yan Song <[email protected]>
hangvane pushed a commit to hangvane/image-service that referenced this issue Apr 7, 2023
@imeoer @hangvane
nydusify: cleanup work directory when conversion finish
965813d 
Remove the work directory to clean up the temporary image
blob data after the conversion is finished.

We should only clean up when the work directory not exists
before, otherwise it may delete user data by mistake.

Fix: dragonflyoss#1162

Signed-off-by: Yan Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ccx1024cc ccx1024cc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nydusify: cleanup work directory when conversion finish imeoer/image-service
1 participant
@ccx1024cc