-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cert.h #336
Update cert.h #336
Conversation
There's something like a "master" certificate you could look for, also make sure it's for the proper GitHub domain as referenced by the firmware url in settings.h I remember having to try a couple different ones when auto updates were first implemented. Possibly @MarkusSchneider has some insight in what certificate to use? |
Reverting changes
Reverted the changes - after digging, the original is on the correct cert - Github's using DigiCert SHA2 High Assurance Server CA |
Adding all Digicert certificates seems to get it working. Added instructions for future changes
Adding all the Digicert certificates seems to fix it. Sent it out to two users for testing |
Can you please add a note in cert.h where you got the new ssl from for future reference? Also need an update to the changelog. Great work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but check the notes above before you merge.
Thanks!
@eMadman You finally solved it 👍. See here for more details: https://www.keyfactor.com/blog/certificate-chain-of-trust/ Good work. |
Ready to merge - pending feedback from another user before I click it. |
I'm comfortable with the changes at this point. Tested on a couple more units - successful attempts at reaching github and downloads of the HTML files |
Still throws an error when trying to connect to check for newer firmware
[ 6772][E][ssl_client.cpp:36] _handle_error(): [start_ssl_client():263]: (-9984) X509 - Certificate verification failed, e.g. CRL, CA or signature check failed
[ 6774][E][WiFiClientSecure.cpp:135] connect(): start_ssl_client: -9984